Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1322540 > unrolled thread

[PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi

Started byVishnu Patekar <vishnupatekar0510@gmail.com>
First post2016-01-31 02:30 +0100
Last post2016-01-31 04:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-01-31 02:30 +0100
    Re: [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to  the dtsi Chen-Yu Tsai <wens@csie.org> - 2016-01-31 04:50 +0100

#1322540 — [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi

FromVishnu Patekar <vishnupatekar0510@gmail.com>
Date2016-01-31 02:30 +0100
Subject[PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi
Message-ID<qWOZY-44I-17@gated-at.bofh.it>
Now that we have a driver for the R_PIO controller,
add the corresponding device node to the dtsi.

Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
---
 arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 5ea20ff..11be9e1 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -478,5 +478,26 @@
 			compatible = "allwinner,sun6i-a31-clock-reset";
 			#reset-cells = <1>;
 		};
+
+		r_pio: pinctrl@01f02c00 {
+			compatible = "allwinner,sun8i-a83t-r-pinctrl";
+			reg = <0x01f02c00 0x400>;
+			interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&apb0_gates 0>;
+			resets = <&apb0_reset 0>;
+			gpio-controller;
+			interrupt-controller;
+			#interrupt-cells = <3>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			#gpio-cells = <3>;
+
+			r_rsb_pins: r_rsb {
+				allwinner,pins = "PL0", "PL1";
+				allwinner,function = "s_rsb";
+				allwinner,drive = <SUN4I_PINCTRL_20_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
+			};
+		};
 	};
 };
-- 
1.9.1

[toc] | [next] | [standalone]


#1322568 — Re: [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi

FromChen-Yu Tsai <wens@csie.org>
Date2016-01-31 04:50 +0100
SubjectRe: [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi
Message-ID<qWRbr-5NN-3@gated-at.bofh.it>
In reply to#1322540
On Sun, Jan 31, 2016 at 9:21 AM, Vishnu Patekar
<vishnupatekar0510@gmail.com> wrote:
> Now that we have a driver for the R_PIO controller,
> add the corresponding device node to the dtsi.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 5ea20ff..11be9e1 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -478,5 +478,26 @@
>                         compatible = "allwinner,sun6i-a31-clock-reset";
>                         #reset-cells = <1>;
>                 };
> +
> +               r_pio: pinctrl@01f02c00 {
> +                       compatible = "allwinner,sun8i-a83t-r-pinctrl";
> +                       reg = <0x01f02c00 0x400>;
> +                       interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&apb0_gates 0>;
> +                       resets = <&apb0_reset 0>;
> +                       gpio-controller;
> +                       interrupt-controller;
> +                       #interrupt-cells = <3>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;

#address-cells and #size-cells aren't needed. They were incorrectly included
in the first place. They were removed from &pio but not &r_pio.

> +                       #gpio-cells = <3>;
> +
> +                       r_rsb_pins: r_rsb {
> +                               allwinner,pins = "PL0", "PL1";
> +                               allwinner,function = "s_rsb";
> +                               allwinner,drive = <SUN4I_PINCTRL_20_MA>;
> +                               allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> +                       };

This setting should be part of the next patch, the RSB node patch.
The rest looks fine.

ChenYu

> +               };
>         };
>  };
> --
> 1.9.1
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web