Re: [PATCH 1/2] staging:iio:adc:added space around '-'

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] staging:iio:adc:added space around '-'
Date	2016-01-30 18:10 +0100
Message-ID	<qWHc7-70c-37@gated-at.bofh.it> (permalink)
References	(3 earlier) <qT1VM-7Ky-9@gated-at.bofh.it> <qUvRL-7sW-7@gated-at.bofh.it> <qUx7c-8gy-7@gated-at.bofh.it> <qWExA-4lM-13@gated-at.bofh.it> <qWFtE-5dN-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2016-01-30 at 18:12 +0300, Dan Carpenter wrote:
> We could make checkpatch.pl not complain if the line says checkpatch:
> on
> it.  It would look like this.
> 
> -               in_voltage-voltage_thresh_low_value,
> +               in_voltage-voltage_thresh_low_value, /* checkpatch:
> not math */
> 
> I suppose I could have made the explanation longer since the it won't
> complain about the 80 character limit...  What do yo/u guys think?

Maybe use a more generic thing like the checkpatch type

               in_voltage-voltage_thresh_low_value, /* checkpatch-SPACING */

Even so, it might uglify checkpatch code a lot to
check something like this per-line or per-block.

And that likely would have to be per line in the
code as checkpatch couldn't see when a patch block
addition occurs outside the scope of a comment.

I suppose inside checkpatch the "sub report {"
function could be extended to look at the specific
$rawline being tested for any "checkpatch" comment
and if so, test if it's the specific $type.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] staging:iio:adc:added space around '-' Jonathan Cameron <jic23@kernel.org> - 2016-01-30 15:20 +0100
  Re: [PATCH 1/2] staging:iio:adc:added space around '-' Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-30 16:20 +0100
    Re: [PATCH 1/2] staging:iio:adc:added space around '-' Lars-Peter Clausen <lars@metafoo.de> - 2016-01-30 16:30 +0100
    Re: [PATCH 1/2] staging:iio:adc:added space around '-' Joe Perches <joe@perches.com> - 2016-01-30 18:10 +0100

csiph-web