Re: [PATCH 1/2] staging:iio:adc:added space around '-'

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] staging:iio:adc:added space around '-'
Date	2016-01-30 15:20 +0100
Message-ID	<qWExA-4lM-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <qRixH-2cl-1@gated-at.bofh.it> <qRj0K-2C0-11@gated-at.bofh.it> <qT1VM-7Ky-9@gated-at.bofh.it> <qUvRL-7sW-7@gated-at.bofh.it> <qUx7c-8gy-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/01/16 17:14, Lars-Peter Clausen wrote:
> On 01/24/2016 05:36 PM, Jonathan Cameron wrote:
>> On 20/01/16 14:21, Dan Carpenter wrote:
>>> On Fri, Jan 15, 2016 at 09:15:52PM +0100, Lars-Peter Clausen wrote:
>>>> On 01/15/2016 08:42 PM, Bhumika Goyal wrote:
>>>>> This patch adds apace around '-' operator.Found using checkpatch.pl
>>>>>
>>>>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>>>>> ---
>>>>>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
>>>>> index f45ebed..0c73bce 100644
>>>>> --- a/drivers/staging/iio/adc/ad7280a.c
>>>>> +++ b/drivers/staging/iio/adc/ad7280a.c
>>>>> @@ -744,14 +744,14 @@ out:
>>>>>  }
>>>>>  
>>>>>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
>>>>> -		in_voltage-voltage_thresh_low_value,
>>>>> +		in_voltage - voltage_thresh_low_value,
>>>>
>>>> Hi,
>>>>
>>>> Thanks for patch. But when sending cleanup patches like this please make
>>>> sure that you a) understand what the code does and how your change affects
>>>> it and b) as a bare minimum of testing perform a compile test, if possible
>>>> also do functional testing.
>>>>
>>>> The patch as it is, is neither semantically nor syntactically correct. As an
>>>> exercise please make sure you understand why.
>>>
>>> Ugh!
>>>
>>> It took me a long time to figure out the bug in this patch...  Why does
>>> that filename have a mix of dashes and underscores?  Too late to fix it
>>> now...  :/
>>>
>> Very deliberately.  The - is indicating it is a differential channel!
>> Literally A minus B.
>>
>> It's an awfully compact representation for maths ;)
>> This is obscured partly in this case as it's specifying an attribute
>> shared by a set of differential channels so it's the generalization
>> of
>> in_voltage0-voltage1_thresh_low_value
>> which does begin to slightly stretch the argument that it is nice and
>> clear ;(
> 
> One thing we should maybe take a look at is making it explicit that this is
> a string so it does not get picked up by checkpatch.
Make sense. Patches welcome :)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] staging:iio:adc:added space around '-' Jonathan Cameron <jic23@kernel.org> - 2016-01-30 15:20 +0100
  Re: [PATCH 1/2] staging:iio:adc:added space around '-' Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-30 16:20 +0100
    Re: [PATCH 1/2] staging:iio:adc:added space around '-' Lars-Peter Clausen <lars@metafoo.de> - 2016-01-30 16:30 +0100
    Re: [PATCH 1/2] staging:iio:adc:added space around '-' Joe Perches <joe@perches.com> - 2016-01-30 18:10 +0100

csiph-web