Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322462

[PATCH 02/14] USB: serial: safe_serial: fix assignment of bool to non 0/1 constant

Show all headers | View raw

This patch fixes the following coccinelle error:

drivers/usb/serial/safe_serial.c:85:12-18: ERROR: Assignment of bool to non-0/1 constant

Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
---
 drivers/usb/serial/safe_serial.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c
index 5662df6..93c6c9b 100644
--- a/drivers/usb/serial/safe_serial.c
+++ b/drivers/usb/serial/safe_serial.c
@@ -76,13 +76,8 @@
 #include <linux/usb.h>
 #include <linux/usb/serial.h>
 
-
-#ifndef CONFIG_USB_SERIAL_SAFE_PADDED
-#define CONFIG_USB_SERIAL_SAFE_PADDED 0
-#endif
-
 static bool safe = true;
-static bool padded = CONFIG_USB_SERIAL_SAFE_PADDED;
+static bool padded = IS_ENABLED(CONFIG_USB_SERIAL_SAFE_PADDED);
 
 #define DRIVER_AUTHOR "sl@lineo.com, tbr@lineo.com, Johan Hovold <jhovold@gmail.com>"
 #define DRIVER_DESC "USB Safe Encapsulated Serial"
-- 
2.6.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] USB: serial: Fix coccinelle warnings Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 06/14] USB: serial: garmin_gps: move constants to right Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 02/14] USB: serial: safe_serial: fix assignment of bool to non 0/1 constant Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 05/14] USB: serial: mos7840: remove comparison to bool Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 13/14] USB: serial: f81232: move constants to right Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 03/14] USB: serial: quatech2: remove comparison to bool Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 11/14] USB: serial: mos7840: move constants to right Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
    Re: [PATCH 11/14] USB: serial: mos7840: move constants to right Bjørn Mork <bjorn@mork.no> - 2016-01-31 22:40 +0100
      Re: [PATCH 11/14] USB: serial: mos7840: move constants to right Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-02-01 13:00 +0100
        Re: [PATCH 11/14] USB: serial: mos7840: move constants to right Bjørn Mork <bjorn@mork.no> - 2016-02-01 13:40 +0100
  [PATCH 10/14] USB: serial: garmin_gps: remove unneeded variable Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 01/14] USB: serial: safe_serial: fix assignment of bool to 0/1 Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  [PATCH 08/14] USB: serial: keyspan: remove unused semicolon Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-01-30 18:50 +0100
  Re: [PATCH 00/14] USB: serial: Fix coccinelle warnings Johan Hovold <johan@kernel.org> - 2016-01-31 21:20 +0100

csiph-web