Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

From	"Li, Weigang" <weigang.li@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support
Date	2016-01-27 09:00 +0100
Message-ID	<qVtbd-cl-13@gated-at.bofh.it> (permalink)
References	<qV710-1ma-3@gated-at.bofh.it> <qV711-1ma-27@gated-at.bofh.it> <qVt1w-7Z-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 1/27/2016 3:41 PM, Herbert Xu wrote:
> On Tue, Jan 26, 2016 at 05:15:06PM +0900, Joonsoo Kim wrote:
>> From: Weigang Li <weigang.li@intel.com>
>>
>> Now, asynchronous compression APIs are supported. There is no asynchronous
>> compression driver now but this APIs can be used as front-end to
>> synchronous compression algorithm. In this case, scatterlist would be
>> linearlized when needed so it would cause some overhead.
>>
>> Signed-off-by: Weigang Li <weigang.li@intel.com>
>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> I think we should be able to use this for the synchronous case
> too, like we do with skcipher and ahash.
>
> The main difference that I can see right now is that acomp always
> allocates a context through the request object while scomp does not.
>
> This difference is entirely artificial as we could also make the
> context conditional for acomp.
>
> The reason we had the shash/ahash division is because the shash
> interface offers a direct pointer interface while ahash is SG-based.
> Otherwise ahash is just as able as shash to handle synchronous
> requests.
>
> At this point in time I don't see such a fundamental distinction
> between acomp and scomp.
>
> Cheers,
>
The acomp is also SG-based, while scomp only accepts flat buffer.

Thread

[PATCH v2 00/10] Introduce new async/sync compression APIs Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
  [PATCH v2 02/10] crypto: add algorithm type specific flag, CRYPTO_ALG_PRIVATE Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
  [PATCH v2 06/10] crypto/lz4: support new compression APIs Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
  [PATCH v2 04/10] crypto/compress: add asynchronous compression support Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
    Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression  support Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 08:50 +0100
      Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression  support "Li, Weigang" <weigang.li@intel.com> - 2016-01-27 09:00 +0100
        Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression  support Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 09:10 +0100
          Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression  support Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 09:10 +0100
            Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression  support "Li, Weigang" <weigang.li@intel.com> - 2016-01-27 09:30 +0100
  [PATCH v2 03/10] crypto/compress: introduce sychronuous compression API Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100

csiph-web