Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318745
| From | "Li, Weigang" <weigang.li@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support |
| Date | 2016-01-27 09:30 +0100 |
| Message-ID | <qVtEd-DF-1@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qV711-1ma-27@gated-at.bofh.it> <qVt1w-7Z-13@gated-at.bofh.it> <qVtbd-cl-13@gated-at.bofh.it> <qVtkR-wF-9@gated-at.bofh.it> <qVtkS-wF-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 1/27/2016 4:09 PM, Herbert Xu wrote: > On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: >> On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: >>> >>> The acomp is also SG-based, while scomp only accepts flat buffer. >> >> Right, but do we need a pointer-based scomp at all? IPComp would >> certainly be better off with an SG-based interface. Any other >> users of compression are presumably dealing with large amounts >> of data where an SG interface would make more sense. >> >> A pointer interface makes sense for shash because you may be hashing >> 16 bytes at a time. Nobody sane is going to be compressing 16 bytes, >> or are they? > > Note that I'm fine with keeping an scomp interface underneath > for those algorithms where the best way to handle SG input is > to linearise things. But I would prefer that this interface is > not exposed to kernel users unless it is absolutely required. > > Cheers, > Thanks for your comments, Herbert. I Agree, SG-list based compression API makes more sense. Maybe Joonsoo can comment on this.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/10] Introduce new async/sync compression APIs Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
[PATCH v2 02/10] crypto: add algorithm type specific flag, CRYPTO_ALG_PRIVATE Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
[PATCH v2 06/10] crypto/lz4: support new compression APIs Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
[PATCH v2 04/10] crypto/compress: add asynchronous compression support Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 08:50 +0100
Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support "Li, Weigang" <weigang.li@intel.com> - 2016-01-27 09:00 +0100
Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 09:10 +0100
Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 09:10 +0100
Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support "Li, Weigang" <weigang.li@intel.com> - 2016-01-27 09:30 +0100
[PATCH v2 03/10] crypto/compress: introduce sychronuous compression API Joonsoo Kim <js1304@gmail.com> - 2016-01-26 09:20 +0100
csiph-web