Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318671

Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node

Show all headers | View raw

On 01/21/2016 09:46 PM, Thierry Reding wrote:
> On Thu, Dec 10, 2015 at 06:11:40PM +0530, Archit Taneja wrote:
>> mipi_dsi_devices are inherently aware of their host because they
>> share a parent-child hierarchy in the device tree.
>>
>> non-dsi drivers that create dsi device don't have this data. In order to
>> get this information, they require to a phandle to the dsi host in the
>> device tree.
>>
>> Maintain a list of all the hosts DSI that are currently registered.
>>
>> This list will be used to find the mipi_dsi_host corresponding to the
>> device_node passed in of_find_mipi_dsi_host_by_node.
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>> Signed-off-by: Archit Taneja <architt@codeaurora.org>
>> ---
>>   drivers/gpu/drm/drm_mipi_dsi.c | 38 ++++++++++++++++++++++++++++++++++++++
>>   include/drm/drm_mipi_dsi.h     |  3 +++
>>   2 files changed, 41 insertions(+)
>
> Please be more consistent with the spelling. Abbreviations should be all
> capitals. Also s/mipi_dsi_devices/MIPI DSI devices/, and so on.

I'll ensure the abbreviations are consistent in the next revision.

>
> Otherwise I guess this makes sense.

Thanks for the review.

Thanks,
Archit

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, hosted by The Linux Foundation

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node Thierry Reding <treding@nvidia.com> - 2016-01-21 17:20 +0100
  Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node Archit Taneja <architt@codeaurora.org> - 2016-01-27 06:30 +0100

csiph-web