Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node

From	Thierry Reding <treding@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node
Date	2016-01-21 17:20 +0100
Message-ID	<qTq7M-7IN-21@gated-at.bofh.it> (permalink)
References	<qAvrk-3rH-3@gated-at.bofh.it> <qE8Pv-6ig-5@gated-at.bofh.it> <qE8Pw-6ig-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Dec 10, 2015 at 06:11:40PM +0530, Archit Taneja wrote:
> mipi_dsi_devices are inherently aware of their host because they
> share a parent-child hierarchy in the device tree.
> 
> non-dsi drivers that create dsi device don't have this data. In order to
> get this information, they require to a phandle to the dsi host in the
> device tree.
> 
> Maintain a list of all the hosts DSI that are currently registered.
> 
> This list will be used to find the mipi_dsi_host corresponding to the
> device_node passed in of_find_mipi_dsi_host_by_node.
> 
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 38 ++++++++++++++++++++++++++++++++++++++
>  include/drm/drm_mipi_dsi.h     |  3 +++
>  2 files changed, 41 insertions(+)

Please be more consistent with the spelling. Abbreviations should be all
capitals. Also s/mipi_dsi_devices/MIPI DSI devices/, and so on.

Otherwise I guess this makes sense.

Thierry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node Thierry Reding <treding@nvidia.com> - 2016-01-21 17:20 +0100
  Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node Archit Taneja <architt@codeaurora.org> - 2016-01-27 06:30 +0100

csiph-web