Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318351

Re: [PATCH] genirq: fix trigger flags check for shared irqs

Show all headers | View raw

On Tue, 26 Jan 2016, Brian Starkey wrote:

> For shared interrupts, if one requester passes in any IRQF_TRIGGER_*
> flags whilst another doesn't, __setup_irq() can erroneously fail.
> 
> The no-flags case should be treated as "already configured", so change
> __setup_irq() to only check that the flags match if any have been
> provided.

What happens if that "already configured", i.e. the default setting, is
conflicting with the newly requested interrupt?

I rather prefer the failure than the resulting silent wreckage.
 
Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] genirq: fix trigger flags check for shared irqs Brian Starkey <brian.starkey@arm.com> - 2016-01-26 11:40 +0100
  Re: [PATCH] genirq: fix trigger flags check for shared irqs Thomas Gleixner <tglx@linutronix.de> - 2016-01-26 21:50 +0100

csiph-web