Re: [PATCH 0/8] General RFKill improvements

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] General RFKill improvements
Date	2016-01-26 14:10 +0100
Message-ID	<qVbxE-4zk-15@gated-at.bofh.it> (permalink)
References	<qSGHE-1px-5@gated-at.bofh.it> <qVbxE-4zk-17@gated-at.bofh.it> <qSGHE-1px-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Tue, 2016-01-19 at 10:42 -0500, João Paulo Rechi Vita wrote:
> This series contains a few general improvements to the RFKill code,
> found while
> I was writing the rfkill-all / airplane mode LED trigger. All were
> points where
> I had to read twice or do some other kind of extra effort to fully
> understand
> it, so I think merging these changes will benefit someone trying to
> understand
> the RFKill subsystem in the future.

I applied some of this. I think we need to keep the "state" sysfs
interface, perhaps you want to document it more clearly. I also didn't
apply the first patch since I'd fixed the suspend/pause issue, please
see if any of your patches remain relevant and resend that.

Thanks,
johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] General RFKill improvements "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-01-19 16:50 +0100
  [PATCH 1/8] rfkill: Documentation and style fixes "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-01-19 16:50 +0100
    Re: [PATCH 1/8] rfkill: Documentation and style fixes Johannes Berg <johannes@sipsolutions.net> - 2016-01-19 21:20 +0100
      Re: [PATCH 1/8] rfkill: Documentation and style fixes João Paulo Rechi Vita <jprvita@gmail.com> - 2016-01-19 21:30 +0100
  Re: [PATCH 0/8] General RFKill improvements Johannes Berg <johannes@sipsolutions.net> - 2016-01-26 14:10 +0100

csiph-web