Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1312481

Re: [PATCH 1/8] rfkill: Documentation and style fixes

From Johannes Berg <johannes@sipsolutions.net>
Newsgroups linux.kernel
Subject Re: [PATCH 1/8] rfkill: Documentation and style fixes
Date 2016-01-19 21:20 +0100
Message-ID <qSKUW-4lv-3@gated-at.bofh.it> (permalink)
References <qSGHE-1px-5@gated-at.bofh.it> <qSGHF-1px-39@gated-at.bofh.it> <qSKUW-4lv-5@gated-at.bofh.it> <qSGHF-1px-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>  /**
>   * rfkill_resume_polling(struct rfkill *rfkill)
>   *
> - * Pause polling -- say transmitter is off for other reasons.
> + * Resume polling previously paused with rfkill_pause_polling.
>   * NOTE: not necessary for suspend/resume -- in that case the
> - * core stops polling anyway
> + * core restarts polling anyway, even if was explicitly paused
> + * before suspending.
>   */

If this is true, that's a bug, no? Drivers would call pause/resume when
their status changes, and shouldn't be required to check status at
resume time?

johannes

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/8] General RFKill improvements "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-01-19 16:50 +0100
  [PATCH 1/8] rfkill: Documentation and style fixes "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-01-19 16:50 +0100
    Re: [PATCH 1/8] rfkill: Documentation and style fixes Johannes Berg <johannes@sipsolutions.net> - 2016-01-19 21:20 +0100
      Re: [PATCH 1/8] rfkill: Documentation and style fixes João Paulo Rechi Vita <jprvita@gmail.com> - 2016-01-19 21:30 +0100
  Re: [PATCH 0/8] General RFKill improvements Johannes Berg <johannes@sipsolutions.net> - 2016-01-26 14:10 +0100

csiph-web