Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1317873
| From | Matthew Wilcox <willy@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: mm: WARNING in __delete_from_page_cache |
| Date | 2016-01-26 14:00 +0100 |
| Message-ID | <qVbo0-4eF-47@gated-at.bofh.it> (permalink) |
| References | <qUqp4-3ue-7@gated-at.bofh.it> <qUBXc-3rR-3@gated-at.bofh.it> <qUOrn-3Og-1@gated-at.bofh.it> <qV2NH-5Hq-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jan 26, 2016 at 03:42:34AM +0000, Williams, Dan J wrote:
> @@ -2907,7 +2912,12 @@ extern void replace_mount_options(struct super_block *sb, char *options);
>
> static inline bool io_is_direct(struct file *filp)
> {
> - return (filp->f_flags & O_DIRECT) || IS_DAX(file_inode(filp));
I think this should just be a one-liner:
- return (filp->f_flags & O_DIRECT) || IS_DAX(file_inode(filp));
+ return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
This does the right thing for block device inodes and filesystem inodes.
(see the opening stanzas of __dax_fault for an example).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
mm: WARNING in __delete_from_page_cache Dmitry Vyukov <dvyukov@google.com> - 2016-01-24 11:50 +0100
Re: mm: WARNING in __delete_from_page_cache "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-01-25 00:10 +0100
Re: mm: WARNING in __delete_from_page_cache Jan Kara <jack@suse.cz> - 2016-01-25 13:30 +0100
Re: mm: WARNING in __delete_from_page_cache "Williams, Dan J" <dan.j.williams@intel.com> - 2016-01-26 04:50 +0100
Re: mm: WARNING in __delete_from_page_cache Jan Kara <jack@suse.cz> - 2016-01-26 09:30 +0100
Re: mm: WARNING in __delete_from_page_cache Matthew Wilcox <willy@linux.intel.com> - 2016-01-26 14:00 +0100
Re: mm: WARNING in __delete_from_page_cache Jan Kara <jack@suse.cz> - 2016-01-26 14:40 +0100
Re: mm: WARNING in __delete_from_page_cache "Williams, Dan J" <dan.j.williams@intel.com> - 2016-01-26 18:00 +0100
Re: mm: WARNING in __delete_from_page_cache Ross Zwisler <zwisler@gmail.com> - 2016-01-27 19:10 +0100
Re: mm: WARNING in __delete_from_page_cache Dmitry Vyukov <dvyukov@google.com> - 2016-01-27 19:10 +0100
csiph-web