Groups > linux.kernel > #1320590

Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2
Date	Thu, 28 Jan 2016 12:40:02 +0100
Message-ID	<qVT5E-2Js-19@gated-at.bofh.it> (permalink)
References	<qVAcG-5tw-23@gated-at.bofh.it> <qVS9B-24O-31@gated-at.bofh.it> <qVSsX-2cx-33@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeblueprint-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=xuk+Wic/7yWLbcrYgyBJ7/xsDfV9VGJgF7tZAIahDRk=; b=Q74Zl3ozWSAZ3ZO3d9rgeeY8oN6S0K/OMmXyWiszpcn7B5rvGVpBZdveUsKTJ4O6bL yRM/egt2IovQD6TWSxiYd+o+eTFFlGxKKw9ablxUVnW8J9jj+Otg520v7YPOAQLXNUFn rNLwaIWEzW6EeMBApNJuT2Qap9XgYkJgmZvhpS9I+3KsFmlKad7F0e41W1k6QxeQjdbZ GTRl4jr+cayXq1BBaFa5WertTcsqjD2ysP6YWZgYpLZU3R9tJnq5SH0uI9U47XfQumdq AQeTRvCqIUyE1xfdT4bXaMwr/xl9QGR8xKRzO3vcfqh+yga74/H/Cpf3sjGklH5uT4fK 9x5g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=xuk+Wic/7yWLbcrYgyBJ7/xsDfV9VGJgF7tZAIahDRk=; b=RNjsdZsZieOX0aTQPGaB09vUUY820aN2jKQXvQ9D3xkWz+BnJ0t+z9FZnmL4i+QdTJ FXpLGQ1GPT+ia7oivzTj415qXBDqTXZVjCiBVaywmzZ9gzSGmFuu0iscv0thI+BqOG4h TVTD+aIXWbOdEbmg7ghD5+GRbWqs4YMd7rHsKKQD7ThrqynwXkbmFRCznYjTxV215Umx THyYS7YoQ7SFafqeCS12DGM39yFB4g3l01AWHuS/AMzMiObEUZQbXueRehq5KNXxxMmw 3iV3h83FG46T4VWLMhJQ7o8KFQAXyOkjnZVVJKtFbYzHI2yNwMYP9n4kSgqLasdIPG32 Glmg==
X-Gm-Message-State	AG10YOReVOPHA1ZAj9HUsFBo45I7s7xf/MpYNbe8eAfeKX5E5DAly8C944BnR/dlynB7lQ==
X-Received	by 10.194.21.135 with SMTP id v7mr2547465wje.131.1453980882264; Thu, 28 Jan 2016 03:34:42 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	11
Organization	linux.* mail to news gateway
X-Original-Cc	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Mike Galbraith <mgalbraith@suse.de>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 28 Jan 2016 11:34:40 +0000
X-Original-Message-ID	<20160128113440.GC2571@codeblueprint.co.uk>
X-Original-References	<1453908566-15211-1-git-send-email-mgorman@techsingularity.net> <20160128103208.GB2571@codeblueprint.co.uk> <20160128105925.GM3162@techsingularity.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1320590

Show key headers only | View raw

On Thu, 28 Jan, at 10:59:25AM, Mel Gorman wrote:
> 
> It wasn't really. The patch increased the function size by enough that
> I uninlined it and let the compiler make the decision. In this case,
> it should automatically inline but I can leave the inline in.

Letting the compiler make the decision seems fine to me, but I'll let
other people chime in with their 'static inline' opinions.

My concern was that you didn't intend to delete the keyword, and it
was done by accident. But since that's not the case, it's no big deal.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched: Make schedstats a runtime tunable that is  disabled by default v2 Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-28 11:40 +0100
  Re: [PATCH] sched: Make schedstats a runtime tunable that is  disabled by default v2 Mel Gorman <mgorman@techsingularity.net> - 2016-01-28 12:00 +0100
    Re: [PATCH] sched: Make schedstats a runtime tunable that is  disabled by default v2 Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-28 12:40 +0100

csiph-web