Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320590

Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2

From Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2
Date 2016-01-28 12:40 +0100
Message-ID <qVT5E-2Js-19@gated-at.bofh.it> (permalink)
References <qVAcG-5tw-23@gated-at.bofh.it> <qVS9B-24O-31@gated-at.bofh.it> <qVSsX-2cx-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 28 Jan, at 10:59:25AM, Mel Gorman wrote:
> 
> It wasn't really. The patch increased the function size by enough that
> I uninlined it and let the compiler make the decision. In this case,
> it should automatically inline but I can leave the inline in.

Letting the compiler make the decision seems fine to me, but I'll let
other people chime in with their 'static inline' opinions.

My concern was that you didn't intend to delete the keyword, and it
was done by accident. But since that's not the case, it's no big deal.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] sched: Make schedstats a runtime tunable that is  disabled by default v2 Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-28 11:40 +0100
  Re: [PATCH] sched: Make schedstats a runtime tunable that is  disabled by default v2 Mel Gorman <mgorman@techsingularity.net> - 2016-01-28 12:00 +0100
    Re: [PATCH] sched: Make schedstats a runtime tunable that is  disabled by default v2 Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-28 12:40 +0100

csiph-web