Groups > linux.kernel > #1320478

Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout
Date	2016-01-28 10:50 +0100
Message-ID	<qVRnc-1sZ-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <qSQH0-8jG-9@gated-at.bofh.it> <qTGvU-2d2-23@gated-at.bofh.it> <qTXn3-5j1-7@gated-at.bofh.it> <qU9ey-5ik-5@gated-at.bofh.it> <qVlGH-3f4-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 27, 2016 at 12:57:43AM +0100, Andi Kleen wrote:
> On Sat, Jan 23, 2016 at 05:19:58PM +0100, Jiri Olsa wrote:
> > On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote:
> > > > > -		if (run == 0 || ena == 0) {
> > > > > -			fprintf(output, "CPU%*d%s%*s%s",
> > > > > -				csv_output ? 0 : -4,
> > > > > -				perf_evsel__cpus(counter)->map[cpu], csv_sep,
> > > > > -				csv_output ? 0 : 18,
> > > > > -				counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> > > > > -				csv_sep);
> > > > 
> > > > this hunk is not preserved in the new code.. I guess the output is
> > > > different for -A if counter wasn't meassure?
> > > 
> > > The code for this is common in printout() now.
> > 
> > but what will be printed for -A not counted counters?
> > not the "CPU%*d%s%*s%s" ...
> 
> 
> CPU0       <not supported>      stalled-cycles-backend                                      
> CPU1       <not supported>      stalled-cycles-backend                                      
> CPU2       <not supported>      stalled-cycles-backend                                      
> CPU3       <not supported>      stalled-cycles-backend                                      
> CPU4       <not supported>      stalled-cycles-backend                                      
> CPU5       <not supported>      stalled-cycles-backend                                      
> CPU6       <not supported>      stalled-cycles-backend                                      
> CPU7       <not supported>      stalled-cycles-backend                                      
> CPU8       <not supported>      stalled-cycles-backend                                      
> CPU9       <not supported>      stalled-cycles-backend                                      
> CPU10      <not supported>      stalled-cycles-backend                                      
> CPU11      <not supported>      stalled-cycles-backend                                      

ah the aggr_printout provides that now.. which wasn't
the case for the removed code

thanks,
jirka

Thread

[PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:30 +0100
  Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Jiri Olsa <jolsa@redhat.com> - 2016-01-22 10:50 +0100
    Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Andi Kleen <andi@firstfloor.org> - 2016-01-23 04:50 +0100
      Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Jiri Olsa <jolsa@redhat.com> - 2016-01-23 17:30 +0100
        Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Andi Kleen <andi@firstfloor.org> - 2016-01-27 01:00 +0100
          Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Jiri Olsa <jolsa@redhat.com> - 2016-01-28 10:50 +0100
    Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Andi Kleen <andi@firstfloor.org> - 2016-01-27 01:00 +0100

csiph-web