Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1315678

Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into printout
Date 2016-01-23 17:30 +0100
Message-ID <qU9ey-5ik-5@gated-at.bofh.it> (permalink)
References <qSQH0-8jG-11@gated-at.bofh.it> <qSQH0-8jG-9@gated-at.bofh.it> <qTGvU-2d2-23@gated-at.bofh.it> <qTXn3-5j1-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jan 23, 2016 at 04:43:05AM +0100, Andi Kleen wrote:
> > > -		if (run == 0 || ena == 0) {
> > > -			fprintf(output, "CPU%*d%s%*s%s",
> > > -				csv_output ? 0 : -4,
> > > -				perf_evsel__cpus(counter)->map[cpu], csv_sep,
> > > -				csv_output ? 0 : 18,
> > > -				counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> > > -				csv_sep);
> > 
> > this hunk is not preserved in the new code.. I guess the output is
> > different for -A if counter wasn't meassure?
> 
> The code for this is common in printout() now.

but what will be printed for -A not counted counters?
not the "CPU%*d%s%*s%s" ...

jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:30 +0100
  Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Jiri Olsa <jolsa@redhat.com> - 2016-01-22 10:50 +0100
    Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Andi Kleen <andi@firstfloor.org> - 2016-01-23 04:50 +0100
      Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Jiri Olsa <jolsa@redhat.com> - 2016-01-23 17:30 +0100
        Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Andi Kleen <andi@firstfloor.org> - 2016-01-27 01:00 +0100
    Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into  printout Andi Kleen <andi@firstfloor.org> - 2016-01-27 01:00 +0100

csiph-web