Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320407

Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path

Show all headers | View raw

On 28-01-16, 12:55, Shilpasri G Bhat wrote:
> cpu_to_chip_id() does a DT walk through to find out the chip id by
> taking a contended device tree lock. This adds an unnecessary overhead
> in a hot path. So instead of calling cpu_to_chip_id() everytime cache
> the chip ids for all cores in the array 'core_to_chip_map' and use it
> in the hotpath.
> 
> Reported-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> ---
> Changes from v6:
> - Minor changes to move the code 'cpumask_copy()' after 'core_to_chip_map'
>   is allocated.
> - Move 'kfree(chips)' to a separate patch.

See, you weren't that bad :)

Just that you missed saying that individual patches contain
version-log in cover-letter :)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
  [PATCH v7 2/6] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
  [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:20 +0100
    Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:40 +0100
    Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:50 +0100
      Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 10:40 +0100
        Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 10:50 +0100
          Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 11:00 +0100
    Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 12:50 +0100
  [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace  print for throttle event Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:20 +0100
    Re: [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace  print for throttle event Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:10 +0100
    Re: [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  [PATCH v7 4/6] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
  Re: [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of  throttle notification and solve bug-fixes in the driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  Re: [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of  throttle notification and solve bug-fixes in the driver Balbir Singh <bsingharora@gmail.com> - 2016-01-28 12:20 +0100

csiph-web