Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320396

Re: [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit

Show all headers | View raw

On 28-01-16, 12:55, Shilpasri G Bhat wrote:
> This will free the dynamically allocated memory of'chips' on
> module exit.

Though it has a 'space' issues before 'chips', but I don't really care
much about that and so you aren't required to resend, unless you have
to send a v8 for something else.

> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> ---
>  drivers/cpufreq/powernv-cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index 547890f..53f980b 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -612,6 +612,7 @@ static void __exit powernv_cpufreq_exit(void)
>  	unregister_reboot_notifier(&powernv_cpufreq_reboot_nb);
>  	opal_message_notifier_unregister(OPAL_MSG_OCC,
>  					 &powernv_cpufreq_opal_nb);
> +	kfree(chips);
>  	cpufreq_unregister_driver(&powernv_cpufreq_driver);
>  }
>  module_exit(powernv_cpufreq_exit);

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
  [PATCH v7 2/6] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
  [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:20 +0100
    Re: [PATCH v7 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from  hot-path Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:40 +0100
    Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:50 +0100
      Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 10:40 +0100
        Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 10:50 +0100
          Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 11:00 +0100
    Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show  throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 12:50 +0100
  [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace  print for throttle event Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:20 +0100
    Re: [PATCH v7 5/6] cpufreq: powernv: Replace pr_info with trace  print for throttle event Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
    Re: [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-28 09:10 +0100
    Re: [PATCH v7 1/6] cpufreq: powernv: Free 'chips' on module exit Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  [PATCH v7 4/6] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-01-28 08:30 +0100
  Re: [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of  throttle notification and solve bug-fixes in the driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 09:30 +0100
  Re: [PATCH v7 0/6] cpufreq: powernv: Redesign the presentation of  throttle notification and solve bug-fixes in the driver Balbir Singh <bsingharora@gmail.com> - 2016-01-28 12:20 +0100

csiph-web