Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320158
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output |
| Date | 2016-01-28 01:10 +0100 |
| Message-ID | <qVIjU-3hE-5@gated-at.bofh.it> (permalink) |
| References | <qVs5r-7WF-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Krzysztof, On 01/27/2016 03:46 AM, Krzysztof Kozlowski wrote: > Cleanup of entire driver of its dmesg output: > 1. Remove printing of the function name, because printing device name is > sufficient. This also makes the dev_err()-like functions more compact > and readable (not need of line break). > 2. Lower from info to debug printing of each RTC interrupt (no need to > make noise on each alarm). > 3. Remove dev_info() at beginning of probe because a message is already > always printed by either probe failure or from registering the RTC > device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] rtc: max77686: Cleanup and reduce dmesg output Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-27 07:50 +0100 Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-28 01:10 +0100 Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output Andi Shyti <andi.shyti@samsung.com> - 2016-01-28 02:20 +0100 Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-31 13:10 +0100
csiph-web