Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1322615

Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output
Date 2016-01-31 13:10 +0100
Message-ID <qWYZk-35l-5@gated-at.bofh.it> (permalink)
References <qVs5r-7WF-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 27/01/2016 at 15:46:11 +0900, Krzysztof Kozlowski wrote :
> Cleanup of entire driver of its dmesg output:
> 1. Remove printing of the function name, because printing device name is
>    sufficient. This also makes the dev_err()-like functions more compact
>    and readable (not need of line break).
> 2. Lower from info to debug printing of each RTC interrupt (no need to
>    make noise on each alarm).
> 3. Remove dev_info() at beginning of probe because a message is already
>    always printed by either probe failure or from registering the RTC
>    device as /dev/rtcX.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> 
> Patch rebased on top of Javier's v4:
> [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support
> http://www.spinics.net/lists/arm-kernel/msg477194.html
> 
> Feel free to join with these series.
> ---
>  drivers/rtc/rtc-max77686.c | 39 ++++++++++++++-------------------------
>  1 file changed, 14 insertions(+), 25 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-31 13:10 +0100

csiph-web