Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315717

Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing sections in test_pages_in_a_zone()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, 2016-01-23 at 15:13 +0100, Willy Tarreau wrote:
> 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Andrew Banman <abanman@sgi.com>
> 
> commit 5f0f2887f4de9508dcf438deab28f1de8070c271 upstream.
[...]
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index f4be464..de19654 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -601,23 +601,30 @@ int is_mem_section_removable(unsigned long start_pfn, unsigned long nr_pages)
>   */
>  static int test_pages_in_a_zone(unsigned long start_pfn, unsigned long end_pfn)
>  {
> -	unsigned long pfn;
> +	unsigned long pfn, sec_end_pfn;
>  	struct zone *zone = NULL;
>  	struct page *page;
>  	int i;
> -	for (pfn = start_pfn;
> +	for (pfn = start_pfn, sec_end_pfn = SECTION_ALIGN_UP(start_pfn);
[...]

SECTION_ALIGN_UP() is not defined in 2.6.32; it was added by commit
a539f3533b78.

Ben.

-- 
Ben Hutchings
Life is what happens to you while you're busy making other plans.
                                                               - John Lennon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing sections in  test_pages_in_a_zone() Willy Tarreau <w@1wt.eu> - 2016-01-23 16:00 +0100
  Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing  sections in test_pages_in_a_zone() Ben Hutchings <ben@decadent.org.uk> - 2016-01-23 19:20 +0100
    Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing sections in test_pages_in_a_zone() Willy Tarreau <w@1wt.eu> - 2016-01-23 19:40 +0100
      Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing sections in test_pages_in_a_zone() Willy Tarreau <w@1wt.eu> - 2016-01-23 20:10 +0100

csiph-web