Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317241

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

From Dave Jones <davej@codemonkey.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default
Date 2016-01-25 20:40 +0100
Message-ID <qUV9w-lx-29@gated-at.bofh.it> (permalink)
References <qTIo2-3up-7@gated-at.bofh.it> <qUJ8l-8rY-1@gated-at.bofh.it> <qUKH8-18J-11@gated-at.bofh.it> <qUUZQ-gp-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 25, 2016 at 02:22:10PM -0500, Dave Jones wrote:

 >  > A default mode would be ok for me as it makes things obvious. Will send
 >  > a patch.
 > 
 > The messaging around changing a default like this was really poor.
 > When we do behaviour changes like this, we typically rename the CONFIG option
 > to make it obvious that things aren't as they used to be.

Looking at this closer, shouldn't the original diff to make this runtime
have also changed the x86 implementation details in arch/x86/mm/pageattr.c ?
Even when we don't boot with the enable flag, we're doing the "split 2M page into 4Ks"
thing.  It looks like a s/debug_pagealloc/debug_pagealloc_enabled()/ might
do the right thing maybe ?

It's almost comedic that I walked into change c9e0d39126af thinking all this
stuff was working _because_ we were doing that page splitting.

	Dave

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-22 12:50 +0100
  Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-25 07:50 +0100
    Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-25 09:30 +0100
      Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Dave Jones <davej@codemonkey.org.uk> - 2016-01-25 20:30 +0100
        Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Dave Jones <davej@codemonkey.org.uk> - 2016-01-25 20:40 +0100
          Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-25 21:00 +0100
            Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-26 07:20 +0100

csiph-web