Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316273

Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default

Show all headers | View raw

On 01/25/2016 07:41 AM, Joonsoo Kim wrote:
> Hello,
> 
> On Fri, Jan 22, 2016 at 12:44:40PM +0100, Christian Borntraeger wrote:
>> since commit 031bc5743f158 ("mm/debug-pagealloc: make debug-pagealloc
>> boottime configurable") CONFIG_DEBUG_PAGEALLOC is by default a no-op.
>>
>> This resulted in several unnoticed bugs, e.g.
>> https://lkml.kernel.org/g/<569F5E29.3090107@de.ibm.com>
>> or
>> https://lkml.kernel.org/g/<56A20F30.4050705@de.ibm.com>
>>
>> as this behaviour change was not even documented in Kconfig.
>>
>> Let's go back to the original default and reverse the command
>> line parameter to allow disabling the feature.
> 
> Default disable is requested by Andrew and I agreed that.
> 
> https://lkml.org/lkml/2014/11/27/3

Well, Andrew's assumption was "I suspect the number of "old users" is one"
and this is wrong. I can at least claim, that most of the s390 test were 
conducted with CONFIG_DEBUG_PAGEALLOC enabled (at least regularly) - and 
about a year ago this was changed to "no longer useful". I have posted 2
real bugs that I triggered pretty quickly after I enabled things on the 
command line.
So my claim is, that the theoretical win of detecting more bugs by enabling 
this on the command line for distro kernels is far less than the real loss
of testers not triggering bugs in the last year.

Let me do some quick check with the kernels that I find in the rpm/deb repos
rawhide: # CONFIG_DEBUG_PAGEALLOC is not set
opensuse leap: # CONFIG_DEBUG_PAGEALLOC is not set
opensuse tumbleweed: # CONFIG_DEBUG_PAGEALLOC is not set
ubuntu 4.3 (kernel team repo) # CONFIG_DEBUG_PAGEALLOC is not set

So at least the communication was not done properly. :-(

> I think that default disable is good thing because we can use
> the kernel compiled with CONFIG_DEBUG_PAGEALLOC even for production.
> Unless boot param is provided, it's runtime cost is nearly zero.
> This could help to debug in some situations and make this debugging
> feature more useful. But, yes, old users can be surprised
> by this change. How about changing Kconfig to ask user for default mode?

A default mode would be ok for me as it makes things obvious. Will send
a patch.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-22 12:50 +0100
  Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-25 07:50 +0100
    Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-25 09:30 +0100
      Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Dave Jones <davej@codemonkey.org.uk> - 2016-01-25 20:30 +0100
        Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Dave Jones <davej@codemonkey.org.uk> - 2016-01-25 20:40 +0100
          Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-25 21:00 +0100
            Re: [PATCH/RFC] mm/debug_pagealloc: enable it by default Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-26 07:20 +0100

csiph-web