Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317233

Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap

Show all headers | View raw

On Mon, Jan 25, 2016 at 8:56 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Mon, 2016-01-25 at 18:02 +0000, Elliott, Robert (Persistent Memory)
> wrote:

>  Using ffs leads to precision runaway

How exactly?!

> and
> exporting an array from string_helpers.c is simply the wrong way to do
> it.

This part I didn't object.

> Since we've now spent more time arguing about this than it would take
> to do a correct patch, this is what I was thinking.  It extracts the
> precision reduction core from string_helpers.c and exposes it to all
> users who want to convert to units.  I added a nozeros option becuase I
> think you want it to print 1 GiB rather than 1.00 GiB for exact powers
> of two.  (OK, and I fixed a bug where it will report small amounts as
> 1.00 B instead of whole number of bytes).  Absent the nozero option,
> you could simply have used string_get_size(), with a block size of 1.

It's good you are doing this better, but I still vote for __ffs64(),
since it would be faster on binary units.

Also, in one version I tried to convert couple of other users which
are using only KM (in general whatever range it would be) units. Any
ideas how to modify to support them?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-23 16:00 +0100
  Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-23 17:50 +0100
    Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-23 18:20 +0100
      Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-23 19:10 +0100
        Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-25 09:40 +0100
          Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-25 16:30 +0100
      Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-23 19:20 +0100
        Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-23 21:40 +0100
          Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap "H. Peter Anvin" <hpa@zytor.com> - 2016-01-23 21:50 +0100
    RE: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2016-01-25 19:10 +0100
      Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-25 20:00 +0100
        Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-25 20:30 +0100
          Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-25 20:50 +0100
            Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-25 21:10 +0100
              Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-25 21:20 +0100
              RE: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2016-01-25 21:40 +0100
                Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-26 13:00 +0100
                Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-26 13:00 +0100
              Re: [PATCH v3 3/4] x86/efi: print size in binary units in  efi_print_memmap James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-25 21:50 +0100

csiph-web