Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316668

Re: [PATCH] clk: tegra: clk-emc: Add missing of_node_put

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Jan 24, 2016 at 08:45:20PM +0530, Amitoj Kaur Chawla wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so
> to break out of the loop an of_node_put is required.
> 
> Found using Coccinelle. The semantic patch used for this is as follows:
> 
> // <smpl>
> @@
> expression e;
> local idexpression child;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/clk/tegra/clk-emc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: tegra: clk-emc: Add missing of_node_put Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-01-24 16:20 +0100
  Re: [PATCH] clk: tegra: clk-emc: Add missing of_node_put Thierry Reding <thierry.reding@gmail.com> - 2016-01-25 14:00 +0100

csiph-web