Re: [PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range
Date	2016-01-23 16:20 +0100
Message-ID	<qU88O-4xQ-7@gated-at.bofh.it> (permalink)
References	<qTu1H-1V0-1@gated-at.bofh.it> <qTPpw-8pj-3@gated-at.bofh.it> <qTRB1-1oj-33@gated-at.bofh.it> <qTRKG-1ss-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jan 22, 2016 at 01:42:33PM -0800, Joe Perches wrote:
> On Fri, 2016-01-22 at 21:31 +0000, Mark Brown wrote:

> > It adds up when you get more flags and these are not in the least bit
> > performance sensitive.

> Sure, but intelligibility is useful too.

I'm really not sure the use of small integers for boolean flags is going
to be an especially troubling barrier for people.

> Do you expect to have more than 4 of these flags?

It's plausible.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] regulator: core: Use a bitfield for continuous_voltage_range Mark Brown <broonie@kernel.org> - 2016-01-21 21:30 +0100
  [PATCH 2/2] regulator: core: Provide per-regulator runtime PM support Mark Brown <broonie@kernel.org> - 2016-01-21 21:30 +0100
    Re: [PATCH 2/2] regulator: core: Provide per-regulator runtime PM  support kbuild test robot <lkp@intel.com> - 2016-01-21 23:00 +0100
  Re: [PATCH 1/2] regulator: core: Use a bitfield for  continuous_voltage_range Joe Perches <joe@perches.com> - 2016-01-22 20:20 +0100
    Re: [PATCH 1/2] regulator: core: Use a bitfield for  continuous_voltage_range Mark Brown <broonie@kernel.org> - 2016-01-22 22:40 +0100
      Re: [PATCH 1/2] regulator: core: Use a bitfield for  continuous_voltage_range Joe Perches <joe@perches.com> - 2016-01-22 22:50 +0100
        Re: [PATCH 1/2] regulator: core: Use a bitfield for  continuous_voltage_range Mark Brown <broonie@kernel.org> - 2016-01-23 16:20 +0100

csiph-web