Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1314525
| From | Shaohua Li <shli@fb.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 3/3] blk-throttling: detect inactive cgroup |
| Date | 2016-01-21 22:10 +0100 |
| Message-ID | <qTuEq-2ry-5@gated-at.bofh.it> (permalink) |
| References | <qT53k-1s5-11@gated-at.bofh.it> <qT53k-1s5-21@gated-at.bofh.it> <qTul4-23q-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jan 21, 2016 at 03:44:05PM -0500, Vivek Goyal wrote: > On Wed, Jan 20, 2016 at 09:49:19AM -0800, Shaohua Li wrote: > > If a cgroup is inactive for some time, it should be excluded from > > bandwidth calculation. > > I am not sure why do we require this patch. If group is inactive, it > will not be on service tree and will not contribute to weight hence > will not contrinute to share. The share calculation is based on existing cgroups (with this patch, existing active cgroups). a cgroup is on service tree when it has pending bios, right? Not having pending bios isn't a condition we should exclude a cgroup. Thanks, Shaohua
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 3/3] blk-throttling: detect inactive cgroup Shaohua Li <shli@fb.com> - 2016-01-20 18:50 +0100
Re: [RFC 3/3] blk-throttling: detect inactive cgroup Vivek Goyal <vgoyal@redhat.com> - 2016-01-21 21:50 +0100
Re: [RFC 3/3] blk-throttling: detect inactive cgroup Shaohua Li <shli@fb.com> - 2016-01-21 22:10 +0100
Re: [RFC 3/3] blk-throttling: detect inactive cgroup Vivek Goyal <vgoyal@redhat.com> - 2016-01-21 22:20 +0100
csiph-web