Re: [PATCH v3] futex: Remove requirement for lock_page in

From	Davidlohr Bueso <dave@stgolabs.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] futex: Remove requirement for lock_page in
Date	2016-01-20 21:30 +0100
Message-ID	<qT7ya-3ae-33@gated-at.bofh.it> (permalink)
References	<qSOYy-702-21@gated-at.bofh.it> <qT75b-2KF-45@gated-at.bofh.it> <qT7eO-33h-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 20 Jan 2016, Thomas Gleixner wrote:

>On Wed, 20 Jan 2016, Davidlohr Bueso wrote:
>> On Tue, 19 Jan 2016, Bueso wrote:
>> > +
>> > +		/* Should be impossible but lets be paranoid for now */
>> > +		BUG_ON(inode->i_mapping != mapping);
>>
>> Hmm, do we want to transform this into an if and do rcu unlock and then just
>> call BUG()? I't doesn't matter at this point _anyway_, but it would be the
>> right
>> thing to do, no?
>
>The better solution is to err out gracefully.
>
>    	   if (WARN_ON_ONCE(inode->i_mapping != mapping) {
>	      	   err = -EFAULT;
>		   rcu_read_unlock();
>		   goto out;
>    	   }
>
>Hmm?

Ok, Linus would probably like that as well. If we're going this way,
we also need to release inode reference, before the rcu unlock.

Thanks,
Davidlohr

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] futex: Remove requirement for lock_page in  Davidlohr Bueso <dave@stgolabs.net> - 2016-01-20 01:40 +0100
  Re: [PATCH v3] futex: Remove requirement for lock_page in Mel Gorman <mgorman@techsingularity.net> - 2016-01-20 15:10 +0100
  Re: [PATCH v3] futex: Remove requirement for lock_page in Davidlohr Bueso <dave@stgolabs.net> - 2016-01-20 21:00 +0100
    Re: [PATCH v3] futex: Remove requirement for lock_page in Thomas Gleixner <tglx@linutronix.de> - 2016-01-20 21:10 +0100
      Re: [PATCH v3] futex: Remove requirement for lock_page in Davidlohr Bueso <dave@stgolabs.net> - 2016-01-20 21:30 +0100

csiph-web