Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1313490

Re: [PATCH v3] futex: Remove requirement for lock_page in

Show all headers | View raw

On Wed, 20 Jan 2016, Davidlohr Bueso wrote:
> On Tue, 19 Jan 2016, Bueso wrote:
> > +
> > +		/* Should be impossible but lets be paranoid for now */
> > +		BUG_ON(inode->i_mapping != mapping);
> 
> Hmm, do we want to transform this into an if and do rcu unlock and then just
> call BUG()? I't doesn't matter at this point _anyway_, but it would be the
> right
> thing to do, no?

The better solution is to err out gracefully.

    	   if (WARN_ON_ONCE(inode->i_mapping != mapping) {
	      	   err = -EFAULT;
		   rcu_read_unlock();
		   goto out;
    	   }

Hmm?

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] futex: Remove requirement for lock_page in  Davidlohr Bueso <dave@stgolabs.net> - 2016-01-20 01:40 +0100
  Re: [PATCH v3] futex: Remove requirement for lock_page in Mel Gorman <mgorman@techsingularity.net> - 2016-01-20 15:10 +0100
  Re: [PATCH v3] futex: Remove requirement for lock_page in Davidlohr Bueso <dave@stgolabs.net> - 2016-01-20 21:00 +0100
    Re: [PATCH v3] futex: Remove requirement for lock_page in Thomas Gleixner <tglx@linutronix.de> - 2016-01-20 21:10 +0100
      Re: [PATCH v3] futex: Remove requirement for lock_page in Davidlohr Bueso <dave@stgolabs.net> - 2016-01-20 21:30 +0100

csiph-web