Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock init

From	Yadwinder Singh Brar <yadi.brar01@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock init
Date	2016-01-19 02:20 +0100
Message-ID	<qSt7I-vW-3@gated-at.bofh.it> (permalink)
References	<qSdmi-6qu-15@gated-at.bofh.it> <qSdmi-6qu-13@gated-at.bofh.it> <qSsEF-4U-7@gated-at.bofh.it> <qSsEF-4U-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>
>> IMHO, with all these modifications, it will leave driver with some extra
>> checks and reduced readability, perhaps will make it complex to add
>> support for similar clocks but with different clk_ops, if next version or
>>  any similar mfd chip comes up in future.
>
> There is no evidence that some future chip will require clk_ops. All of
> them are so far exactly the same. Even the newly added S2MPS15 is the same.
>

Can we guaranty about future chips?
Even we didn't expect there will be one less clock in case of s2mps14.

> This really should be simplified.
>

IMO, it is just reduction of LoC.

Regards,
Yadwinder

Thread

[PATCH 2/2] clk: s2mps11: allocate only one structure for clock init Andi Shyti <andi.shyti@samsung.com> - 2016-01-18 09:30 +0100
  Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock  init Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-19 00:50 +0100
  Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock  init Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-19 01:50 +0100
    Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock init Yadwinder Singh Brar <yadi.brar01@gmail.com> - 2016-01-19 02:20 +0100
  Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock  init Andi Shyti <andi.shyti@samsung.com> - 2016-01-19 03:50 +0100
    Re: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock init Yadwinder Singh Brar <yadi.brar01@gmail.com> - 2016-01-19 09:10 +0100

csiph-web