Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311876

Re: [PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for lazy mbind

Show all headers | View raw

Hello Liang,

Just trivial comment below.

On Mon, 18 Jan 2016, Liang Chen wrote:

> VM_HUGETLB and VM_MIXEDMAP vma needs to be excluded to avoid compound
> pages being marked for migration and unexpected COWs when handling
> hugetlb fault.
>
> Thanks to Naoya Horiguchi for reminding me on these checks.
>
> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
> Signed-off-by: Gavin Guo <gavin.guo@canonical.com>
> ---
> mm/mempolicy.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 436ff411..415de70 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -610,8 +610,9 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
>
> 	if (flags & MPOL_MF_LAZY) {
> 		/* Similar to task_numa_work, skip inaccessible VMAs */
> -		if (vma_migratable(vma) &&
> -			vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
> +		if (vma_migratable(vma) && !is_vm_hugetlb_page(vma) &&
> +			(vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE)) &&
> +			!(vma->vm_flags & VM_MIXEDMAP))

Isn't there exists few unnecessary parenthesis? IMHO, it makes me hard to 
read the code.

How about below code, instead?

+             if (vma_migratable(vma) && !is_vm_hugetlb_page(vma) &&
+                     vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE) &&
+                     !vma->vm_flags & VM_MIXEDMAP)


Thanks,
SeongJae Park.

> 			change_prot_numa(vma, start, endvma);
> 		return 1;
> 	}
> -- 
> 1.9.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for lazy mbind Liang Chen <liangchen.linux@gmail.com> - 2016-01-18 15:10 +0100
  Re: [PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for  lazy mbind SeongJae Park <sj38.park@gmail.com> - 2016-01-19 02:20 +0100
    Re: [PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for  lazy mbind Gavin Guo <gavin.guo@canonical.com> - 2016-01-19 03:50 +0100
      Re: [PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for  lazy mbind SeongJae Park <sj38.park@gmail.com> - 2016-01-19 04:10 +0100
        Re: [PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for  lazy mbind Liang Chen <liangchen.linux@gmail.com> - 2016-01-20 14:50 +0100
  Re: [PATCH] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for  lazy mbind David Rientjes <rientjes@google.com> - 2016-01-19 23:30 +0100
    [PATCH v2] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for lazy mbind Liang Chen <liangchen.linux@gmail.com> - 2016-01-20 15:10 +0100
      Re: [PATCH v2] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA  for lazy mbind David Rientjes <rientjes@google.com> - 2016-01-21 00:40 +0100

csiph-web