[PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	[PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()
Date	Mon, 18 Jan 2016 20:40:02 +0100
Message-ID	<qSnOG-5b4-5@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.5.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, Nicolas Ferre <nicolas.ferre@atmel.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Belloni <alexandre.belloni@free-electrons.com>
X-Original-Date	Mon, 18 Jan 2016 20:34:58 +0100
X-Original-Message-ID	<1453145698-23661-1-git-send-email-alexandre.belloni@free-electrons.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1311769

Show key headers only | View raw

ret is used to detect an error but it was not properly updated after
calling clk_prepare_enable() thus it made it impossible to detect an error
when enabling the slow clock.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/clocksource/timer-atmel-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index 29d21d68df5a..c69070c6ad91 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node)
 	if (IS_ERR(sclk))
 		panic(pr_fmt("Unable to get slow clock\n"));
 
-	clk_prepare_enable(sclk);
+	ret = clk_prepare_enable(sclk);
 	if (ret)
 		panic(pr_fmt("Could not enable slow clock\n"));
 
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: atmel-st: use return value from clk_prepare_enable() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-18 20:40 +0100
  Re: [PATCH] clocksource: atmel-st: use return value from  clk_prepare_enable() Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-19 09:40 +0100
  Re: [PATCH] clocksource: atmel-st: use return value from  clk_prepare_enable() Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-01-19 10:00 +0100

csiph-web