Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311995

Re: [PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()

Show all headers | View raw

Le 18/01/2016 20:34, Alexandre Belloni a écrit :
> ret is used to detect an error but it was not properly updated after
> calling clk_prepare_enable() thus it made it impossible to detect an error
> when enabling the slow clock.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/clocksource/timer-atmel-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> index 29d21d68df5a..c69070c6ad91 100644
> --- a/drivers/clocksource/timer-atmel-st.c
> +++ b/drivers/clocksource/timer-atmel-st.c
> @@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node)
>  	if (IS_ERR(sclk))
>  		panic(pr_fmt("Unable to get slow clock\n"));
>  
> -	clk_prepare_enable(sclk);
> +	ret = clk_prepare_enable(sclk);

Yes, sure...
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks!


>  	if (ret)
>  		panic(pr_fmt("Could not enable slow clock\n"));
>  
> 


-- 
Nicolas Ferre

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: atmel-st: use return value from clk_prepare_enable() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-18 20:40 +0100
  Re: [PATCH] clocksource: atmel-st: use return value from  clk_prepare_enable() Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-19 09:40 +0100
  Re: [PATCH] clocksource: atmel-st: use return value from  clk_prepare_enable() Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-01-19 10:00 +0100

csiph-web