Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311711
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform |
| Date | 2016-01-18 18:50 +0100 |
| Message-ID | <qSm6d-3ZZ-5@gated-at.bofh.it> (permalink) |
| References | <qSeLp-7gM-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 01/18/16 01:51, Arnd Bergmann wrote:
> During my randconfig build testing, I found that a kernel with
> DEBUG_AT91_UART and ARCH_BCM_63XX fails to build:
>
> arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror]
>
> It turns out that the DEBUG_UART_BCM63XX option is enabled whenever
> the ARCH_BCM_63XX is, and that breaks multiplatform kernels because
> we then end up using the UART address from BCM63XX rather than the
> one we actually configured (if any).
>
> This changes the BCM63XX options to only have one Kconfig option,
> and only enable that if the user explicitly turns it on.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b51312bebfa4 ("ARM: BCM63XX: add low-level UART debug support")
> Cc: stable@vger.kernel.org
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index c57cbb7e8179..4a2c6a3bc90a 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -153,10 +153,10 @@ choice
> mobile SoCs in the Kona family of chips (e.g. bcm28155,
> bcm11351, etc...)
>
> - config DEBUG_BCM63XX
> + config DEBUG_BCM63XX_UART
> bool "Kernel low-level debugging on BCM63XX UART"
> depends on ARCH_BCM_63XX
> - select DEBUG_UART_BCM63XX
> + help
What's with the empty help message (and lots of trailing whitespace)?
>
> config DEBUG_BERLIN_UART
> bool "Marvell Berlin SoC Debug UART"
--
~Randy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Arnd Bergmann <arnd@arndb.de> - 2016-01-18 11:00 +0100
Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Randy Dunlap <rdunlap@infradead.org> - 2016-01-18 18:50 +0100
Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Arnd Bergmann <arnd@arndb.de> - 2016-01-18 20:40 +0100
Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Florian Fainelli <f.fainelli@gmail.com> - 2016-01-18 20:10 +0100
csiph-web