Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1313118
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] usb: phy-am335x: clarify USB_COMMON dependency |
| Date | Wed, 20 Jan 2016 12:00:03 +0100 |
| Message-ID | <qSYEz-5ea-29@gated-at.bofh.it> (permalink) |
| X-Original-To | Bin Liu <b-liu@ti.com> |
| User-Agent | KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 7Bit |
| Content-Type | text/plain; charset="us-ascii" |
| X-Provags-ID | V03:K0:3vtR5Xbkg/TDqZUWNoImzP/XPOGGVz5C7UzjaWegixBfE0Eppom JhMzSobnITmLer+5AQAYWanryQNUpDFm9nF+cz9ggdJZb0E9gGqLjcaqQP/JGaq8bI1LXdm EhcnO4eH5Fs+/9xLBHsCc6oHC0ZLWeb+IVRw8buwMXL693wV5wfmUTIEAqFX3wmgqzFsdkU ggghKCoYz5hhxcyBEGXdQ== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:y2hfqK2ZuuY=:ky9O9rwdNmsyOkObsK1eWe 5d/0jyh0yXG4tZ8+IJdeFOkXj60lxAy+l2dp7xKImJSqm6vzZ70a+LOlK3TVEjNMKumQcWDZj 801H5H0DAhJWntgqzNCQRyWZM+lfqQJaeAv65iR+qED/YMr1okBpiwPOfqjjmMlOKHVKrGv43 bd9QTWkORamemOYwIz5l1Jl7w+exQoJuOVV0TwN9GhUwLLdczowjxz5fAhdtM3V3laSoIB7NK BME7JmJeyvETe/X/pxq/6hNcuFYXo4A99zvvKxmqvyFBbLfrfVY3y8cXh2DeX8d728It5FuxB 2wzxO6WXO4LQU7UqfS+/0UMIMpbLRAzXujt56VqMV5XOoGIVKZr4ztujmB+3cXA58Bk1zYUj4 kQkzFhoFMCF89+DMDA3mECuFbJrTxzps20vD/205xLrwtK6SqAV+nxN+zvOqzQX6Vi6XbQ0r9 AaicCPhUOc4cey7rpuPvWRUhteYgEopm1V9Wt2kcveoTWyNWR3IgOC0+TZs3X8tat3dv9dAyh jVT4KoXY0Cd+LWNIDz+RcD8JHF9bWAEQj0ES/nDPGEZVrpXyia01HX2ZvlQo9bDvMh0CT6/cC 2oHtS5+q6RgdaM8CG03LqXGZs2hPdSR30yrqkkZcEiebJRSvX+KuDjaIUgVCKgYlF9gMo/095 knrgNL+So0vClibWkLzHH3poOyunm3SMsvkev+tdeQX5llQFqh7eYTGsbcq4tGbbkOL7IXGdQ dUO3hdhEs9P/mqTR |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 28 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Felipe Balbi <balbi@ti.com>, balbif@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Wed, 20 Jan 2016 11:56:34 +0100 |
| X-Original-Message-ID | <1749004.q1rSF7t8cz@wuerfel> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1313118 |
Show key headers only | View raw
The phy-am335x driver accidentally selects 'USB_COMMON', which is
not correct as that symbol should indicate whether USB host or
target mode is enabled, but it might not:
warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
This changes the 'select' into 'depends on', as it should have
been initially.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index c6904742e2aa..29f063c59e1a 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -63,10 +63,10 @@ config AM335X_CONTROL_USB
config AM335X_PHY_USB
tristate "AM335x USB PHY Driver"
depends on ARM || COMPILE_TEST
+ depends on USB_COMMON
select USB_PHY
select AM335X_CONTROL_USB
select NOP_USB_XCEIV
- select USB_COMMON
help
This driver provides PHY support for that phy which part for the
AM335x SoC.
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] usb: phy-am335x: clarify USB_COMMON dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-20 12:00 +0100 Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Bin Liu <b-liu@ti.com> - 2016-01-20 19:10 +0100
csiph-web