[PATCH] usb: phy-am335x: clarify USB_COMMON dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] usb: phy-am335x: clarify USB_COMMON dependency
Date	2016-01-20 12:00 +0100
Message-ID	<qSYEz-5ea-29@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The phy-am335x driver accidentally selects 'USB_COMMON', which is
not correct as that symbol should indicate whether USB host or
target mode is enabled, but it might not:

warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))

This changes the 'select' into 'depends on', as it should have
been initially.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index c6904742e2aa..29f063c59e1a 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -63,10 +63,10 @@ config AM335X_CONTROL_USB
 config AM335X_PHY_USB
 	tristate "AM335x USB PHY Driver"
 	depends on ARM || COMPILE_TEST
+	depends on USB_COMMON
 	select USB_PHY
 	select AM335X_CONTROL_USB
 	select NOP_USB_XCEIV
-	select USB_COMMON
 	help
 	  This driver provides PHY support for that phy which part for the
 	  AM335x SoC.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: phy-am335x: clarify USB_COMMON dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-20 12:00 +0100
  Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Bin Liu <b-liu@ti.com> - 2016-01-20 19:10 +0100

csiph-web