Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1312857

Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

Show all headers | View raw

On 2016/1/20 1:30, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:31:59PM +0800, Chen Feng wrote:
> 
>> Chen Feng (5):
>>   doc: bindings: Add document for mfd hi665x PMIC
>>   doc: bindings: Document for hi655x regulator driver
>>   mfd: hi655x: Add hi665x pmic driver
>>   regulator: add regulator driver of hi655x pmic
>>   hisilicon/dts: Add hi655x pmic dts node
> 
> I've asked you several times to use subject lines reflecting the style
> for the subsystem for the DT bindings (and have just noticed that the
> same thing applies to the DTS update).
> 
Mark,

Really sorry for this.
Since I have not caught what you mean before this time.

I changed the style problem from doc:bindings to doc: bindings.
A blank space added. But this was not accurately what you mean.

I will change it like this:
bindings: mfd: hi655x: Add document for mfd hi665x PMIC
bindings: regulator: hi655x: Document for hi655x regulator driver
regulator: hi655x: add regulator driver of hi655x pmic
arm64: dts: hisilicon: Add hi655x pmic dts node

Will this be okay?

Have you also reviewed the regulator driver code? I changed it to
of_match and regulators_node without opening code.

Thanks again for your advice.

Feng

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng <puck.chen@hisilicon.com> - 2016-01-19 07:40 +0100
  [PATCH v6 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng <puck.chen@hisilicon.com> - 2016-01-19 07:40 +0100
  [PATCH v6 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng <puck.chen@hisilicon.com> - 2016-01-19 07:40 +0100
  [PATCH v6 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng <puck.chen@hisilicon.com> - 2016-01-19 07:40 +0100
  [PATCH v6 4/5] regulator: add regulator driver of hi655x pmic Chen Feng <puck.chen@hisilicon.com> - 2016-01-19 07:40 +0100
  Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Mark Brown <broonie@kernel.org> - 2016-01-19 18:40 +0100
    Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core chenfeng <puck.chen@hisilicon.com> - 2016-01-20 05:00 +0100
      Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Mark Brown <broonie@kernel.org> - 2016-01-20 12:50 +0100
        Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core chenfeng <puck.chen@hisilicon.com> - 2016-01-21 11:20 +0100

csiph-web