Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1310380

Re: [PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx()

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx()
Date Fri, 15 Jan 2016 20:10:03 +0100
Message-ID <qRhV0-1WI-29@gated-at.bofh.it> (permalink)
References <qRcVk-6OR-27@gated-at.bofh.it>
X-Original-To Geert Uytterhoeven <geert@linux-m68k.org>
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Disposition inline
Content-Transfer-Encoding 8bit
User-Agent Mutt/1.5.24 (2015-08-30)
X-Scanned-By MIMEDefang 2.68 on 10.5.11.23
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 15
Organization linux.* mail to news gateway
X-Original-Cc Vlad Yasevich <vyasevich@gmail.com>, Neil Horman <nhorman@tuxdriver.com>, "David S. Miller" <davem@davemloft.net>, Xin Long <lucien.xin@gmail.com>, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Fri, 15 Jan 2016 17:05:32 -0200
X-Original-Message-ID <20160115190532.GH6074@mrl.redhat.com>
X-Original-References <1452865471-32509-1-git-send-email-geert@linux-m68k.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1310380

Show key headers only | View raw


On Fri, Jan 15, 2016 at 02:44:31PM +0100, Geert Uytterhoeven wrote:
> net/sctp/proc.c: In function ‘sctp_transport_get_idx’:
> net/sctp/proc.c:313: warning: ‘obj’ may be used uninitialized in this function
> 
> This is currently a false positive, as all callers check for a zero
> offset first, and handle this case in the exact same way.
> 
> Move the check and handling into sctp_transport_get_idx() to kill the
> compiler warning, and avoid future bugs.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Compile-tested only.

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-15 14:50 +0100
  Re: [PATCH] net: sctp: Move sequence start handling into  sctp_transport_get_idx() Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-01-15 20:10 +0100
  Re: [PATCH] net: sctp: Move sequence start handling into  sctp_transport_get_idx() David Miller <davem@davemloft.net> - 2016-01-15 21:20 +0100

csiph-web