Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1310380

Re: [PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx()

From Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx()
Date 2016-01-15 20:10 +0100
Message-ID <qRhV0-1WI-29@gated-at.bofh.it> (permalink)
References <qRcVk-6OR-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 15, 2016 at 02:44:31PM +0100, Geert Uytterhoeven wrote:
> net/sctp/proc.c: In function ‘sctp_transport_get_idx’:
> net/sctp/proc.c:313: warning: ‘obj’ may be used uninitialized in this function
> 
> This is currently a false positive, as all callers check for a zero
> offset first, and handle this case in the exact same way.
> 
> Move the check and handling into sctp_transport_get_idx() to kill the
> compiler warning, and avoid future bugs.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Compile-tested only.

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-15 14:50 +0100
  Re: [PATCH] net: sctp: Move sequence start handling into  sctp_transport_get_idx() Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-01-15 20:10 +0100
  Re: [PATCH] net: sctp: Move sequence start handling into  sctp_transport_get_idx() David Miller <davem@davemloft.net> - 2016-01-15 21:20 +0100

csiph-web