Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309896

RE: [PATCH] input: cyapa: fix the report events may lost issue during set power mode

Show all headers | View raw

Jeremiah,

Thanks for your help to do test and verification.

Regards,
Dudley

> -----Original Message-----
> From: Jeremiah Mahler [mailto:jmmahler@gmail.com]
> Sent: 2016?1?15? 13:34
> To: Dudley Du
> Cc: dmitry.torokhov@gmail.com; eugenesan@gmail.com; bleung@google.com;
> linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] input: cyapa: fix the report events may lost issue during set
> power mode
>
> Dudley,
>
> On Thu, Jan 14, 2016 at 01:40:33PM +0800, Dudley Du wrote:
> > When driver set the power mode to change the scan rate in auto suspend
> > process, some events may be lost because
> > 1) for gen3 trackpad, the driver must msleep() some time to avoid issuing
> > next command encounter error;
> > 2) for gen5 and later trackpads, the queue dumping function will simply
> > ignore the events when waiting for the set power mode command response.
> > so, when auto resume process will be executed, the set power mode command
> > will be issued can cause the events may be lost.
> > The solution is kept polling and report those valid events when the set
> > power mode command is in progress.
> >
> > TEST=test on Acer C720P Chromebook
> >
> > Signed-off-by: Dudley Du <dudl@cypress.com>
> > ---
> >  drivers/input/mouse/cyapa.c      |  22 ++++----
> >  drivers/input/mouse/cyapa.h      |  14 ++++-
> >  drivers/input/mouse/cyapa_gen3.c | 108
> ++++++++++++++++++++++++++++-----------
> >  drivers/input/mouse/cyapa_gen5.c |  99
> +++++++++++++++++++++++++++++------
> >  drivers/input/mouse/cyapa_gen6.c |   4 +-
> >  5 files changed, 188 insertions(+), 59 deletions(-)
> >
> [...]
>
> I tested this on my Acer C720 and it appears to work properly.
>
> Tested-by: Jeremiah Mahler <jmmahler@gmail.com>
>
> --
> - Jeremiah Mahler

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] input: cyapa: fix the report events may lost issue during set power mode Dudley Du <dudl@cypress.com> - 2016-01-14 07:10 +0100
  Re: [PATCH] input: cyapa: fix the report events may lost issue  during set power mode Jeremiah Mahler <jmmahler@gmail.com> - 2016-01-15 06:40 +0100
    RE: [PATCH] input: cyapa: fix the report events may lost issue during  set power mode Dudley Du <dudl@cypress.com> - 2016-01-15 07:50 +0100

csiph-web