Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309877

Re: [PATCH] input: cyapa: fix the report events may lost issue during set power mode

Show all headers | View raw

Dudley,

On Thu, Jan 14, 2016 at 01:40:33PM +0800, Dudley Du wrote:
> When driver set the power mode to change the scan rate in auto suspend
> process, some events may be lost because
> 1) for gen3 trackpad, the driver must msleep() some time to avoid issuing
> next command encounter error;
> 2) for gen5 and later trackpads, the queue dumping function will simply
> ignore the events when waiting for the set power mode command response.
> so, when auto resume process will be executed, the set power mode command
> will be issued can cause the events may be lost.
> The solution is kept polling and report those valid events when the set
> power mode command is in progress.
> 
> TEST=test on Acer C720P Chromebook
> 
> Signed-off-by: Dudley Du <dudl@cypress.com>
> ---
>  drivers/input/mouse/cyapa.c      |  22 ++++----
>  drivers/input/mouse/cyapa.h      |  14 ++++-
>  drivers/input/mouse/cyapa_gen3.c | 108 ++++++++++++++++++++++++++++-----------
>  drivers/input/mouse/cyapa_gen5.c |  99 +++++++++++++++++++++++++++++------
>  drivers/input/mouse/cyapa_gen6.c |   4 +-
>  5 files changed, 188 insertions(+), 59 deletions(-)
> 
[...]

I tested this on my Acer C720 and it appears to work properly.

Tested-by: Jeremiah Mahler <jmmahler@gmail.com>

-- 
- Jeremiah Mahler

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] input: cyapa: fix the report events may lost issue during set power mode Dudley Du <dudl@cypress.com> - 2016-01-14 07:10 +0100
  Re: [PATCH] input: cyapa: fix the report events may lost issue  during set power mode Jeremiah Mahler <jmmahler@gmail.com> - 2016-01-15 06:40 +0100
    RE: [PATCH] input: cyapa: fix the report events may lost issue during  set power mode Dudley Du <dudl@cypress.com> - 2016-01-15 07:50 +0100

csiph-web