Re: Nokia N900: u-SD card in v4.2+

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: Nokia N900: u-SD card in v4.2+
Date	2016-01-13 20:30 +0100
Message-ID	<qQzhg-48x-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <qObCq-3GI-1@gated-at.bofh.it> <qOh57-7sH-3@gated-at.bofh.it> <qPauC-3CC-19@gated-at.bofh.it> <qPGkN-8j2-9@gated-at.bofh.it> <qQz7A-44Y-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Pavel Machek <pavel@ucw.cz> [160113 11:13]:
> On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> > 
> > 'select' is generally not recommended since it selects a config without
> > caring for the dependency. With adding 'depends on', MMC won't be enabled and
> > will end up in the same problem.
> 
> Well... it really should "depend on". Not ideal, but you'll likely
> realize what went on.
> 
> Silently compiling known-bad kernel is ... well.. bad.

Force selects will lead into build errors sooner or later.

> > Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> > should be enabled for MMCs to work.
> > commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> > Author: Tony Lindgren <tony@atomide.com>
> > Date:   Mon Oct 12 16:19:54 2015 -0700
> > 
> >     Documentation: ARM: List new omap MMC requirements
> > 
> > Maybe we should also make the error message a little more verbose to tell the
> > user that CONFIG_REGULATOR_PBIAS be selected?
> 
> That would help.
> 
> As would #error if we recognize broken config.

Can't we just add a check to the omap_hsmmc.c? In cases where
MMC1 has the PBIAS regulator configured but not available, print
an error about missing CONFIG_REGULATOR_PBIAS error and return
-EPROBE_DEFER?

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Nokia N900: u-SD card in v4.2+ Pavel Machek <pavel@ucw.cz> - 2016-01-06 21:50 +0100
  Re: Nokia N900: u-SD card in v4.2+ Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-07 06:50 +0100
    Re: Nokia N900: u-SD card in v4.2+ Pavel Machek <pavel@ucw.cz> - 2016-01-07 12:40 +0100
      Re: Nokia N900: u-SD card in v4.2+ Pali Rohár <pali.rohar@gmail.com> - 2016-01-09 23:50 +0100
        Re: Nokia N900: u-SD card in v4.2+ Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-11 09:50 +0100
          Re: Nokia N900: u-SD card in v4.2+ Pavel Machek <pavel@ucw.cz> - 2016-01-13 20:20 +0100
            Re: Nokia N900: u-SD card in v4.2+ Tony Lindgren <tony@atomide.com> - 2016-01-13 20:30 +0100

csiph-web