Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305957

Re: Nokia N900: u-SD card in v4.2+

Show all headers | View raw

Hi,

On Sunday 10 January 2016 04:14 AM, Pali Rohár wrote:
> On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:
>> Hi!
>>
>>> On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
>>>> Hi!
>>>>
>>>> In v4.1, both internal MMC and u-SD cards work ok.
>>>>
>>>> In v4.2, only the internal MMC is detected. In v4.3, not even
>>>> internal MMC works. In v4.4, only the internal MMC is detected.
>>>>
>>>> Does it work for you? Any patches?
>>>
>>> I don't have Nokia N900 to check this, but can you share your
>>> config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present
>>> in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all
>>> omap3+ SoCs to work.
>>
>> I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.
>>
>> I wonder if we should add some selects, so that users updating from
>> old kernels don't break their system?
> 
> Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too, 
> because I just updated defconfig from older kernel version.

'select' is generally not recommended since it selects a config without
caring for the dependency. With adding 'depends on', MMC won't be enabled and
will end up in the same problem.

Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
should be enabled for MMCs to work.
commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
Author: Tony Lindgren <tony@atomide.com>
Date:   Mon Oct 12 16:19:54 2015 -0700

    Documentation: ARM: List new omap MMC requirements

Maybe we should also make the error message a little more verbose to tell the
user that CONFIG_REGULATOR_PBIAS be selected?

Thanks
Kishon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Nokia N900: u-SD card in v4.2+ Pavel Machek <pavel@ucw.cz> - 2016-01-06 21:50 +0100
  Re: Nokia N900: u-SD card in v4.2+ Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-07 06:50 +0100
    Re: Nokia N900: u-SD card in v4.2+ Pavel Machek <pavel@ucw.cz> - 2016-01-07 12:40 +0100
      Re: Nokia N900: u-SD card in v4.2+ Pali Rohár <pali.rohar@gmail.com> - 2016-01-09 23:50 +0100
        Re: Nokia N900: u-SD card in v4.2+ Kishon Vijay Abraham I <kishon@ti.com> - 2016-01-11 09:50 +0100
          Re: Nokia N900: u-SD card in v4.2+ Pavel Machek <pavel@ucw.cz> - 2016-01-13 20:20 +0100
            Re: Nokia N900: u-SD card in v4.2+ Tony Lindgren <tony@atomide.com> - 2016-01-13 20:30 +0100

csiph-web