Re: [PATCH 1/2] x86/msr: add on cpu read/modify/write function

From	Jacob Pan <jacob.jun.pan@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] x86/msr: add on cpu read/modify/write function
Date	2016-01-13 02:20 +0100
Message-ID	<qQigp-HG-1@gated-at.bofh.it> (permalink)
References	<qEEFI-29G-15@gated-at.bofh.it> <qEEFI-29G-17@gated-at.bofh.it> <qHMno-1aw-15@gated-at.bofh.it>
Organization	OTC

Show all headers | View raw

On Sun, 20 Dec 2015 14:28:48 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:

> So this is a copy of the above !SMP inline. What's wrong with
> providing:
> 
>  int rmwmsrl_safe(msr_no, clear_mask, set_mask)
> 
> in x86/lib/msr.c and make the !SMP variant of rdmsrl_safe_on_cpu()
> and that variant for the SMP case a simple wrapper around it?
> 
> static void remote_rmwmsrl_safe(void *info)
> {
> 	struct msr_action *ma = info;
> 
> 	return rmwmsrl_safe(ma->msr, ma->clear_mask, ma->set_mask);
> }
> 
> No gotos, no pointless code duplication. Just simple.
much better, just sent new code in v2. Sorry for the delay.

Thanks

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] x86/msr: add on cpu read/modify/write function Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-01-13 02:20 +0100

csiph-web