Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c from dtb

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c from dtb
Date	2016-01-13 01:00 +0100
Message-ID	<qQh11-88E-19@gated-at.bofh.it> (permalink)
References	<qQ2EG-6Ka-1@gated-at.bofh.it> <qQ4du-7Y1-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12.01.2016 19:11, Andi Shyti wrote:
> In some architectures the L2 cache controller is integrated in the
> processor's block itself and it doesn't use any external cache
> controller. This means that an entry in the board's dtb related
> to the l2c is not necessary.
> 
> Distinguish between error codes and do not print anything in case
> l2x0_of_init() doesn't find any L2C DTB entry and returns -ENODEV.
> 
> This patch mutes the following error message:
> 
>    L2C: failed to init: -19
> 
> on boards like odroid-xu4, cortex A7/A15, which don't have
> external cache controller.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> Hi,
> 
> here is a second version. An alternative would be to print with
> pr_dbg, but then it's a matter of taste.
> 
> V1, and V2 print a message in case the l2c dtb entry is not found
> (the V2 has a better print rephrase suggested by Joe)
> 
> V3 ignores the case of -enodev for l2c and doesn't print anything
> 
> Thanks,
> Andi

Looks good to me, as v2 did. Works fine:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

BR,
KRzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm: irq: l2c: do not print error in case of missing l2c from  dtb Andi Shyti <andi.shyti@samsung.com> - 2016-01-12 07:40 +0100
  Re: [PATCH] arm: irq: l2c: do not print error in case of missing  l2c from dtb Joe Perches <joe@perches.com> - 2016-01-12 08:20 +0100
    [PATCH v2] arm: irq: l2c: do not print error in case of missing l2c  from dtb Andi Shyti <andi.shyti@samsung.com> - 2016-01-12 08:30 +0100
      Re: [PATCH v2] arm: irq: l2c: do not print error in case of missing  l2c from dtb Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-12 09:30 +0100
    Re: [PATCH] arm: irq: l2c: do not print error in case of missing l2c  from dtb Marek Szyprowski <m.szyprowski@samsung.com> - 2016-01-12 09:40 +0100
      [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c  from dtb Andi Shyti <andi.shyti@samsung.com> - 2016-01-12 11:20 +0100
        Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing  l2c from dtb Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 01:00 +0100

csiph-web