Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307048

[PATCH v2] arm: irq: l2c: do not print error in case of missing l2c from dtb

Show all headers | View raw

In some architectures the L2 cache controller is integrated in the
processor's block itself and it doesn't use any external cache
controller. This means that an entry in the board's dtb related
to the l2c is not necessary.

Distinguish between error codes and print just an information in
case of -ENODEV.

This patch converts the following error message:

   L2C: failed to init: -19

to the following info:

   L2C: no controller entry found in the dtb

on boards like odroid-xu4, cortex A7/A15, which don't have
external cache controller.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---

Thanks Joe,

makes sense!

Andi

 arch/arm/kernel/irq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
index 1d45320..714b5d6 100644
--- a/arch/arm/kernel/irq.c
+++ b/arch/arm/kernel/irq.c
@@ -95,7 +95,9 @@ void __init init_IRQ(void)
 			outer_cache.write_sec = machine_desc->l2c_write_sec;
 		ret = l2x0_of_init(machine_desc->l2c_aux_val,
 				   machine_desc->l2c_aux_mask);
-		if (ret)
+		if (ret == -ENODEV)
+			pr_info("L2C: no controller entry found in the dtb\n");
+		else if (ret)
 			pr_err("L2C: failed to init: %d\n", ret);
 	}
 
-- 
2.6.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm: irq: l2c: do not print error in case of missing l2c from  dtb Andi Shyti <andi.shyti@samsung.com> - 2016-01-12 07:40 +0100
  Re: [PATCH] arm: irq: l2c: do not print error in case of missing  l2c from dtb Joe Perches <joe@perches.com> - 2016-01-12 08:20 +0100
    [PATCH v2] arm: irq: l2c: do not print error in case of missing l2c  from dtb Andi Shyti <andi.shyti@samsung.com> - 2016-01-12 08:30 +0100
      Re: [PATCH v2] arm: irq: l2c: do not print error in case of missing  l2c from dtb Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-12 09:30 +0100
    Re: [PATCH] arm: irq: l2c: do not print error in case of missing l2c  from dtb Marek Szyprowski <m.szyprowski@samsung.com> - 2016-01-12 09:40 +0100
      [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c  from dtb Andi Shyti <andi.shyti@samsung.com> - 2016-01-12 11:20 +0100
        Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing  l2c from dtb Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 01:00 +0100

csiph-web