Re: [PATCH 1/3] ifb: make device count build-time configurable

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ifb: make device count build-time configurable
Date	2016-01-12 22:00 +0100
Message-ID	<qQecO-6d2-11@gated-at.bofh.it> (permalink)
References	<qQ5Me-nk-9@gated-at.bofh.it> <qQ6Ih-11c-13@gated-at.bofh.it> <qQcb0-4UQ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 12 Jan 2016 10:44:37 -0800

> On Tue, 12 Jan 2016 07:55:22 -0500
> Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> 
>> On 16-01-12 06:56 AM, Lubomir Rintel wrote:
>> > The devices can be created at run-time for quite some time already and the
>> > load-time device creation collides with attempts to create the device of
>> > the same name:
>> >
>> >    # rmmod ifb
>> >    # ip link add ifb0 type ifb
>> >    RTNETLINK answers: File exists
>> >
>> > This is pretty much the same situation as was with the block loop devices
>> > which was solved by adding a build-time configuration that the
>> > distributions could use as they deem fit while keeping the default for
>> > compatibility.
>> >
>> > Let's do that here as well.
>> >
>> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>> 
>> I guess module options are frowned upon. so:
> 
> I would prefer that this were done with a module parameter, the same as dummy.
> Only developers build their own configured kernels. Having the value set later
> at module load time is preferable.

I like this even less, it means tools behave significantly differently
based upon what module options were passed to the kernel.

Module options really should not change kernel behavior like this..

Thread

[PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 13:00 +0100
  Re: [PATCH 1/3] ifb: make device count build-time configurable Jamal Hadi Salim <jhs@mojatatu.com> - 2016-01-12 14:00 +0100
    Re: [PATCH 1/3] ifb: make device count build-time configurable Stephen Hemminger <stephen@networkplumber.org> - 2016-01-12 19:50 +0100
      Re: [PATCH 1/3] ifb: make device count build-time configurable David Miller <davem@davemloft.net> - 2016-01-12 22:00 +0100
  Re: [PATCH 1/3] ifb: make device count build-time configurable Tom Gundersen <teg@jklm.no> - 2016-01-12 16:20 +0100
  Re: [PATCH 1/3] ifb: make device count build-time configurable Daniel Borkmann <daniel@iogearbox.net> - 2016-01-12 16:30 +0100
    Re: [PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 16:40 +0100
      [PATCH v2] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 16:40 +0100
        Re: [PATCH v2] ifb: make device count build-time configurable David Miller <davem@davemloft.net> - 2016-01-12 21:50 +0100
    Re: [PATCH 1/3] ifb: make device count build-time configurable Daniel Borkmann <daniel@iogearbox.net> - 2016-01-12 16:40 +0100
      Re: [PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 16:50 +0100
        Re: [PATCH 1/3] ifb: make device count build-time configurable Daniel Borkmann <daniel@iogearbox.net> - 2016-01-12 17:10 +0100

csiph-web