Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307546

Re: [PATCH 1/3] ifb: make device count build-time configurable

Show all headers | View raw

On 01/12/2016 12:56 PM, Lubomir Rintel wrote:
> The devices can be created at run-time for quite some time already and the
> load-time device creation collides with attempts to create the device of
> the same name:
>
>    # rmmod ifb
>    # ip link add ifb0 type ifb
>    RTNETLINK answers: File exists
>
> This is pretty much the same situation as was with the block loop devices
> which was solved by adding a build-time configuration that the
> distributions could use as they deem fit while keeping the default for
> compatibility.
>
> Let's do that here as well.

Thanks for the set in general, good to see it fixed!

> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
[...]
> +config IFB_COUNT
> +        int "Number of ifb devices to pre-create at init time"
> +        depends on IFB
> +        default 3

Should that not be 2?

> +        help
> +          Static number of ifb devices to be unconditionally pre-created
> +          at init time.
> +
> +          This default value can be overwritten on the kernel command
> +          line or with module-parameter ifb.numifbs.
> +
> +          The historic default is 3. If a mid-2007 version of iproute2
> +          is used (v2.6.23 or later), it can be set to 0, since needed
> +          ifb devices can be dynamically allocated via rtnetlink.

[...]
> -static int numifbs = 2;
               ^^^^^^^^^^^^
> +static int numifbs = CONFIG_IFB_COUNT;
>   module_param(numifbs, int, 0);
>   MODULE_PARM_DESC(numifbs, "Number of ifb devices");

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 13:00 +0100
  Re: [PATCH 1/3] ifb: make device count build-time configurable Jamal Hadi Salim <jhs@mojatatu.com> - 2016-01-12 14:00 +0100
    Re: [PATCH 1/3] ifb: make device count build-time configurable Stephen Hemminger <stephen@networkplumber.org> - 2016-01-12 19:50 +0100
      Re: [PATCH 1/3] ifb: make device count build-time configurable David Miller <davem@davemloft.net> - 2016-01-12 22:00 +0100
  Re: [PATCH 1/3] ifb: make device count build-time configurable Tom Gundersen <teg@jklm.no> - 2016-01-12 16:20 +0100
  Re: [PATCH 1/3] ifb: make device count build-time configurable Daniel Borkmann <daniel@iogearbox.net> - 2016-01-12 16:30 +0100
    Re: [PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 16:40 +0100
      [PATCH v2] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 16:40 +0100
        Re: [PATCH v2] ifb: make device count build-time configurable David Miller <davem@davemloft.net> - 2016-01-12 21:50 +0100
    Re: [PATCH 1/3] ifb: make device count build-time configurable Daniel Borkmann <daniel@iogearbox.net> - 2016-01-12 16:40 +0100
      Re: [PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 16:50 +0100
        Re: [PATCH 1/3] ifb: make device count build-time configurable Daniel Borkmann <daniel@iogearbox.net> - 2016-01-12 17:10 +0100

csiph-web