Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309245

RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A

Show all headers | View raw

Hi Peter,

> -----Original Message-----
> From: Peter Korsgaard [mailto:jacmet@gmail.com] On Behalf Of Peter Korsgaard
> Sent: 2016年1月14日 19:43
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
> Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark
> Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>;
> Kumar Gala <galak@codeaurora.org>; Krzysztof Kozlowski
> <k.kozlowski@samsung.com>; devicetree@vger.kernel.org; Ferre, Nicolas
> <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org; Javier Martinez
> Canillas <javier@dowhile0.org>; Lee Jones <lee.jones@linaro.org>; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
> ACT8945A
> 
> >>>>> "Yang," == Yang, Wenyou <Wenyou.Yang@atmel.com> writes:
> 
> Hi,
> 
> >>
>  >>> Isn't the regulator part of the act8945a identical to act8865? Can't we just
> use  >>> the existing act8865-regulator.c driver? (E.G. support 8865 variant in the
> mfd  >>> driver, but only register the regulator sub device?)  >>  >> > Yes, the
> regulator part of the act8945a is identical to act8865.
>  >>
>  >> > But the act8865-regulator driver is a struct i2c_driver, and the mfd  > sub-
>   >> device driver is a platform_driver driver, it is not easy to use  > it.
>  >>
>  >> But the mfd driver could support the act8865 variant as well (by only
> registering  >> the regulator mfd cell).
> 
>  > I still don't understand.
> 
>  > The MFD sub device is registered as a platform device, the existing  > act8865
> driver is registered as an i2c_driver. How do they match? :)
> 
>  > Could you point out which exiting driver for me to reference.  Thank you!
> 
> What I'm saying is that it isn't nice that we end up with both act8865-regulator.c
> and act8954-regulator.c doing 95% the same. This can either be fixed by:
> 
> - Adding act8865 support to your mfd driver (but only registering the
>   regulator subdev for act8865) and changing the existing
>   act8865-regulator driver to work as a mfd subdev (platform device)
> 
> - Extending the act8865-regulator driver to register as a platform
>   driver in ADDITION to a i2c driver so it can be used with mfd. The
>   driver already uses regmap so it should only be a matter of adding the
>   pdev probe/remove functions.

Thank you for so detail information, I will do as you said.


Thanks & Best Regards,
Wenyou Yang

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] regulator: act8945a: add regulator driver for the sub-device of ACT8945A MFD Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-12 09:20 +0100
  [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-12 09:20 +0100
    Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Peter Korsgaard <peter@korsgaard.com> - 2016-01-13 15:30 +0100
      RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for  ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-14 02:30 +0100
        Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for  ACT8945A Lee Jones <lee.jones@linaro.org> - 2016-01-14 07:30 +0100
        Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Peter Korsgaard <peter@korsgaard.com> - 2016-01-14 08:30 +0100
          RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for  ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-14 09:10 +0100
            Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Peter Korsgaard <peter@korsgaard.com> - 2016-01-14 12:50 +0100
              RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for  ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-14 13:50 +0100
  [PATCH v2 2/2] regulator: add documentation for ACT8945A's regulator DT bindings Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-12 09:30 +0100

csiph-web