Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1309041
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A |
| Date | 2016-01-14 07:30 +0100 |
| Message-ID | <qQJzX-33f-1@gated-at.bofh.it> (permalink) |
| References | <qQ2lj-6CM-1@gated-at.bofh.it> <qQ2lk-6CM-15@gated-at.bofh.it> <qQuAX-X1-29@gated-at.bofh.it> <qQETE-83s-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 14 Jan 2016, Yang, Wenyou wrote:
> > -----Original Message-----
> > From: Peter Korsgaard [mailto:jacmet@gmail.com] On Behalf Of Peter Korsgaard
> > Sent: 2016年1月13日 22:22
> > To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> > Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
> > Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark
> > Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>;
> > Kumar Gala <galak@codeaurora.org>; Krzysztof Kozlowski
> > <k.kozlowski@samsung.com>; devicetree@vger.kernel.org; Ferre, Nicolas
> > <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org; Javier Martinez
> > Canillas <javier@dowhile0.org>; Lee Jones <lee.jones@linaro.org>; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
> > ACT8945A
> >
> > >>>>> "Wenyou" == Wenyou Yang <wenyou.yang@atmel.com> writes:
> >
> > > This patch adds new regulator driver to support ACT8945A MFD > chip's
> > regulators.
> >
> > > The ACT8945A has three step-down DC/DC converters and four > low-dropout
> > regulators.
> >
> > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> >
> > Isn't the regulator part of the act8945a identical to act8865? Can't we just use the
> > existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd driver,
> > but only register the regulator sub device?)
>
> Yes, the regulator part of the act8945a is identical to act8865.
>
> But the act8865-regulator driver is a struct i2c_driver, and the mfd sub-device driver is a platform_driver driver, it is not easy to use it.
Take a look at some existing files with the pattern
drivers/mfd/*{spi,i2c,core}.c to see how this might be possible.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] regulator: act8945a: add regulator driver for the sub-device of ACT8945A MFD Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-12 09:20 +0100
[PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-12 09:20 +0100
Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Peter Korsgaard <peter@korsgaard.com> - 2016-01-13 15:30 +0100
RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-14 02:30 +0100
Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Lee Jones <lee.jones@linaro.org> - 2016-01-14 07:30 +0100
Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Peter Korsgaard <peter@korsgaard.com> - 2016-01-14 08:30 +0100
RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-14 09:10 +0100
Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Peter Korsgaard <peter@korsgaard.com> - 2016-01-14 12:50 +0100
RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-14 13:50 +0100
[PATCH v2 2/2] regulator: add documentation for ACT8945A's regulator DT bindings Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-12 09:30 +0100
csiph-web